-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar not scrollable anymore with Giscus comment presented at after body. #1567
Comments
Thanks for reporting. I'll investigate tomorrow. |
Thanks! I'll be looking forward to see it fixed! |
Hey, I have posted a potential fix, can you check if #1574 fixes your issue? |
Hi @saberzero1, thanks for the prompt fix. I manually applied #1574 and it works! Now my site is working properly with the giscus! Thanks for the help and I'll close this issue. |
Hey @LumenYoung, I'm glad it fixes your issue. I'm going to reopen this issue until the proposed fix has been merged into Quartz for all users to prevent confusion for others running into this issue. |
Describe the bug
As I described in the title. I find that when 1) the left sidebar (possibly right sidebar as well, but haven't test it) has content exceeding the current viewable area and 2) when the giscus comment area presents. We lost the ability to scroll on the left side bar.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would expect either
Screenshots and Source
I can provide upon request.
You can visit my site www.lumeny.io for a look at the problem. A fun finding is that the sidebar is in a short period of time scrollable before the giscus component is loaded (feel free to try on my site). My quartz codebase is at here.
Desktop (please complete the following information):
Additional context
Thanks for this amazing work! I can't think of blogging to be sooo rewarding if not with quartz.
The text was updated successfully, but these errors were encountered: