Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar not scrollable anymore with Giscus comment presented at after body. #1567

Open
LumenYoung opened this issue Nov 4, 2024 · 5 comments · May be fixed by #1574
Open

Sidebar not scrollable anymore with Giscus comment presented at after body. #1567

LumenYoung opened this issue Nov 4, 2024 · 5 comments · May be fixed by #1574
Labels
bug Something isn't working

Comments

@LumenYoung
Copy link

LumenYoung commented Nov 4, 2024

Describe the bug

As I described in the title. I find that when 1) the left sidebar (possibly right sidebar as well, but haven't test it) has content exceeding the current viewable area and 2) when the giscus comment area presents. We lost the ability to scroll on the left side bar.

To Reproduce
Steps to reproduce the behavior:

  1. extend your sidebar so that it doesn't fit one page
  2. enable the comment
  3. try to scroll, either on the main area or on the sidebar
  4. See that the side bar stops moving even it is not depleted yet.

Expected behavior

I would expect either

  1. if the main content is depleted, the sidebar should start scrolling down (which was the case when no giscus widget has been loaded yet.
  2. or if I place my cursor on the sidebar or click on that area, the focus should shift to the area and scroll that part.

Screenshots and Source
I can provide upon request.

You can visit my site www.lumeny.io for a look at the problem. A fun finding is that the sidebar is in a short period of time scrollable before the giscus component is loaded (feel free to try on my site). My quartz codebase is at here.

Desktop (please complete the following information):

  • Quartz Version: v4.4

Additional context
Thanks for this amazing work! I can't think of blogging to be sooo rewarding if not with quartz.

@LumenYoung LumenYoung added the bug Something isn't working label Nov 4, 2024
@LumenYoung LumenYoung changed the title Left sidebar not scrollable with Giscus comment presented at after body. Sidebar not scrollable anymore with Giscus comment presented at after body. Nov 4, 2024
@saberzero1
Copy link
Collaborator

Thanks for reporting. I'll investigate tomorrow.

@LumenYoung
Copy link
Author

Thanks! I'll be looking forward to see it fixed!

@saberzero1
Copy link
Collaborator

Thanks! I'll be looking forward to see it fixed!

Hey, I have posted a potential fix, can you check if #1574 fixes your issue?

@LumenYoung
Copy link
Author

Hi @saberzero1, thanks for the prompt fix.

I manually applied #1574 and it works! Now my site is working properly with the giscus!

Thanks for the help and I'll close this issue.

@saberzero1
Copy link
Collaborator

Hey @LumenYoung, I'm glad it fixes your issue.

I'm going to reopen this issue until the proposed fix has been merged into Quartz for all users to prevent confusion for others running into this issue.

@saberzero1 saberzero1 reopened this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants