Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fetch to be an object #13

Open
jackfranklin opened this issue Mar 26, 2018 · 2 comments
Open

Allow fetch to be an object #13

jackfranklin opened this issue Mar 26, 2018 · 2 comments

Comments

@jackfranklin
Copy link
Owner

Currently we only allow fetch(url, options) but we should support fetch(options) where options.url is passed.

(I think right now it will work but it isn't supported by TypeScript)
JohnLindahlTech added a commit to nordnet/so-fetch that referenced this issue Jan 7, 2020
@JohnLindahlTech
feat: jackfranklin#13 fetch now accepts only ifetchoptions.
60c3713
@JohnLindahlTech JohnLindahlTech mentioned this issue Jan 7, 2020
Closed
@JohnLindahlTech
Copy link

See my PR #21 that this is actually possible even with typescript.

@JohnLindahlTech
Copy link

JohnLindahlTech commented Jan 7, 2020 •
edited
Loading

The implementation landed in that rootUrl will be added even when {url: '/any/end/point'} is used. This can be changed of course to allow for overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #13 fetch now accepts only ifetchoptions. nordnet/so-fetch
2 participants
@jackfranklin @JohnLindahlTech