-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove call to future standard_library.install_aliases() #24
Comments
As far as I can tell modernize is just a 2to3 fixer like futurize, but unlike python-future doesn't backport modules from python 3 to python 2. One has to use modernize with six in order to write code that is valid python 2 and python 3. Since we are already have futurized the code, reverting it back and then modernizing it seems like a waste of time, especially since the changes that futurize made were pretty conservative (See f86c386 and ea940f8) So I suggest we ignore modernize for now. The question becomes then, should we use python-future or six? Future without The only thing we'll miss from future if we don't use The worse thing that we will do to other modules if we use future is that we may return Given this I think it's better if we continue to use future, without |
Sounds reasonable to me! |
This is not safe to use in a library.
Also, please review the use of future in this library to make sure it is conservative enough not to cause trouble for other users of the library.
(or maybe consider modernize instead)
See #20 (comment)
The text was updated successfully, but these errors were encountered: