Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build failure on OCaml 4.03 and above #6

Open
gasche opened this issue Aug 12, 2016 · 1 comment
Open

build failure on OCaml 4.03 and above #6

gasche opened this issue Aug 12, 2016 · 1 comment

Comments

@gasche
Copy link

gasche commented Aug 12, 2016

This package uses internal parsetree definitions that changed in 4.03.

See the opam-builder report in http://opam.ocamlpro.com/builder/html/gensqlite/gensqlite.0.1/4e11133f38685ec7bdbb1630e8ff1c83.

Would it be possible to make a new release that is compatible with 4.03 and above?
@j0sh
Copy link
Owner

j0sh commented Aug 12, 2016

Thanks for the heads up!

Now that sqlexpr supports ppx, I'm not sure if there is a place for this library anymore. Perhaps it would be best to restrict this to OCaml <4.0.3 and declare it deprecated?

gasche added a commit to gasche/opam-repository that referenced this issue Aug 12, 2016
@gasche
gensqlite: mark incompatibility with ocaml >= 4.03
2e919bd 
opam-builder report:
  http://opam.ocamlpro.com/builder/html/gensqlite/gensqlite.0.1/4e11133f38685ec7bdbb1630e8ff1c83

Discussion with upstream:
  j0sh/ocaml-gensqlite#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j0sh @gasche