Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in compute_ps and aggregate_ps #32

Open
aguang opened this issue Aug 6, 2024 · 1 comment
Open

bug in compute_ps and aggregate_ps #32

aguang opened this issue Aug 6, 2024 · 1 comment
Assignees
@j-stat

Comments

@aguang
Copy link
Collaborator

aguang commented Aug 6, 2024

There is a bug in compute_ps and aggregate_ps, will provide a reproducible example when possible. Need to fix bug and update tests to include tests for the 2 functions.
@j-stat
Copy link
Owner

j-stat commented Aug 20, 2024

Pushed a fix along with unit test for this, thanks August!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-stat j-stat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aguang @j-stat