Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_shank functionality and further clarify what shank spacing is in ghedt #100

Open
j-c-cook opened this issue Feb 1, 2022 · 0 comments
Labels
new feature New features
Milestone

Comments

@j-c-cook
Copy link
Owner

j-c-cook commented Feb 1, 2022

The following function needs to be completed. The function will set the shank spacing based on A, B or C options defined in Paul's MS thesis.

ghedt/ghedt/utilities.py

Lines 58 to 68 in 93d159c

# TODO: Add `set_shank` functionality to utilities.py
# def set_shank(configuration: str, rb: float, r_in: float, r_out: float):
# raise ValueError('This function is incomplete.')
# if configuration == 'A':
# a = 1
# elif configuration == 'B':
# a = 1
# elif configuration == 'C':
# a = 1
# else:
# raise ValueError('Only configurations A, B, or C are valid.')

@mitchute mentions that the shank spacing s value in ghedt should be further clarified:

https://gist.github.com/mitchute/151522d67cdc21058ac523881f4e7957?permalink_comment_id=4049526#gistcomment-4049526

@j-c-cook j-c-cook added the new feature New features label Feb 6, 2022
@j-c-cook j-c-cook added this to the Version 0.3 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New features
Projects
None yet
Development

No branches or pull requests

1 participant