How to group links with optional parameter

[SlamDevelop]

For grouping I use the pattern, but the problem is that everything works only when the url is specified with the language, without the language it gives an error.

These links work

• test.com/eng
• test.com/eng/page
• test.com/eng/admin/page

But these links do not work

• test.com
• test.com/page
• test.com/admin/page

$patterns = array(
    ':lang' => 'ua|ru|eng|de'
);
$router->pattern($patterns);

$router->group(':lang?', function($router) {
    $router->get('/', function() {
        return 'Front';
    });

    $router->get('page', function() {
        return 'Front - page';
    });


    $router->group('admin', function($router) {
        $router->get('/', function() {
            return 'Admin';
        });

        $router->get('page', function() {
            return 'Admin - page';
        });
    });
});

How to solve this problem? Thank you in advance.

[SlamDevelop]

@izniburak Can you help me figure it out?

[izniburak]

Hi @SlamDevelop ,
I will check the problem in my local and give information about that to you. If there is any problem about patterns for Groups, I will try to fix it and release a new version ASAP.

Thanks.

[Evrim267]

Hi @izniburak and @SlamDevelop did you find a solution for this problem?

[AlexJMcloud]

Most likely I understand how to solve it. You create your own pattern, but you do not add it to the existing class pattern. Here you can solve the methods of adding to the array of patterns.

[AlexJMcloud]

/** * @param array $pattern * @return bool */ protected function addPattern(array $pattern):bool { if(!empty($pattern)) { $this->patterns = array_merge($this->patterns, $pattern); return true; } return false; }

[AlexJMcloud]

$patterns = array( ':lang' => 'ua|ru|eng|de' ); $router->addPattern($patterns);

[AlexJMcloud]

"$router->pattern($patterns);" - Haven't tried using the built-in . But I'll watch it later

[AlexJMcloud]

`/**
* Add new route rules pattern; String or Array
*
* @param array|string $pattern
* @param string|null $attr
*
* @return true
* @throws
*/
public function pattern(array|string $pattern, string $attr = null): bool
{
if (is_array($pattern)) {
foreach ($pattern as $key => $value) {
if (array_key_exists($key, $this->patterns)) {
$this->exception($key . ' pattern cannot be changed.');
}
$this->patterns[$key] = '(' . $value . ')';
}
} else {
if (array_key_exists($pattern, $this->patterns)) {
$this->exception($pattern . ' pattern cannot be changed.');
}
$this->patterns[$pattern] = '(' . $attr . ')';
}

    return true;
}`

Or replace with this. My language change works within the pattern