Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvexPartition_OPT fails on some polys #35

Open
abakobo opened this issue Jan 30, 2019 · 2 comments
Open

ConvexPartition_OPT fails on some polys #35

abakobo opened this issue Jan 30, 2019 · 2 comments

Comments

@abakobo
Copy link

abakobo commented Jan 30, 2019

Hi

ConvexPartition_HM seems to work with any input polygon. But ConvexPartition_OPT seems to fail with larger(?) polys.
The attached file contains a poly that will not be Partitionned with _OPT (an empty list is returned). With _HM it will be partitionned correctly though.

Best Regards

polyfourte.txt

@ivanfratric
Copy link
Owner

Thank you for reporting this! Given that I haven't been doing any computational geometry for a while now, any help in figuring out the root cause would be greatly appreciated. ConvexPartition_OPT does have an O(n^3) space complexity so it wouldn't be well suited for very large polygons, but for 69 points (like in the example you provided) it should work fine.

@aaronfranke
Copy link
Contributor

Confirmed, running Triangulate_OPT on this polygon results in a blank image, no data is output. Everything except Triangulate_OPT works on this polygon.

Here's an updated test case: issue-35.txt, here are some test outputs: issue-35.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants