Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit (or return) code of executable if Error occurred #307

Open
csaf4370 opened this issue Aug 20, 2015 · 2 comments
Open

Exit (or return) code of executable if Error occurred #307

csaf4370 opened this issue Aug 20, 2015 · 2 comments
Assignees

Comments

@csaf4370
Copy link
Member

Currently the return code for failed simulations (e.g. db init failed) is 0.
could the return code be != 0 if something critical failed?

attozeta pushed a commit that referenced this issue Aug 20, 2015
This reverts commit 5248049.
attozeta pushed a commit that referenced this issue Aug 20, 2015
This reverts commit c6ad549. Now
it is getting funny.
attozeta pushed a commit that referenced this issue Aug 20, 2015
This reverts commit 4e183d0. WTF.
@attozeta attozeta self-assigned this Aug 20, 2015
@attozeta attozeta reopened this Aug 20, 2015
@attozeta
Copy link
Contributor

Unfortunately 5248049 does not resolve the issue as we will ALWAYS fail to load some stuff which is ignored at the moment. This may also be related to #308.

You get a full list via

dynamind --loglevel 0 <mymodel.dyn>

which shows quite some stuff that we whould never try to load (like e.g. CMakeLists.txt) which resides in $BUILD/output/PythonModules/scripts.

However I agree that we should fail early, so reopened.

@christianurich
Copy link
Member

Yeah, that is designed chaos. If modules are added through the Directory method it tries every file in the folder. Should be fine to remove this option just register the individual files.

Another thing would be using the simulation status, it should return an error code if the execution of check fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants