Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extraDeploy array #170

Merged
merged 14 commits into from
Sep 2, 2023
Merged

Added extraDeploy array #170

merged 14 commits into from
Sep 2, 2023

Conversation

grantbruneau
Copy link
Contributor

Adds extraDeploy array which allows us to include additional objects at deployment. My reason for this is to use helm pre-install/post-delete hooks which can automatically add/remove DNS entries for my minecraft servers.

Reference

itzg
itzg previously approved these changes Sep 2, 2023
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itzg
Copy link
Owner

itzg commented Sep 2, 2023

The lint build failure probably isn't related to your change, but I'm not sure yet why it fails with

curl: (6) getaddrinfo() thread failed to start

@grantbruneau
Copy link
Contributor Author

The lint build failure probably isn't related to your change, but I'm not sure yet why it fails with

curl: (6) getaddrinfo() thread failed to start

Looks like there was an error downloading bedrock at that moment. Can we retry the lint? I confirmed that URL works.
ERROR failed to download from https://minecraft.azureedge.net/bin-linux/bedrock-server-1.20.15.01.zip

@itzg
Copy link
Owner

itzg commented Sep 2, 2023

Had already re-run, but was waiting to try again today since it might have been a github workflow networking issue.

@itzg
Copy link
Owner

itzg commented Sep 2, 2023

Still failing in the same way. I really don't think it's related to your changes, so I'll experiment with a PR with no changes from master.

@grantbruneau
Copy link
Contributor Author

grantbruneau commented Sep 2, 2023

Seems like it might be the github runner, has anything changed on that end? My googling says maybe firewall issue.

Edit: Actually, this is all from within KIND, so maybe not runner specifically.

@grantbruneau
Copy link
Contributor Author

@itzg I have it working on my fork. I updated the versions of KIND and metallb. Prior to that I had the same errors.

reference

@itzg
Copy link
Owner

itzg commented Sep 2, 2023

Thanks! Running it now

@itzg
Copy link
Owner

itzg commented Sep 2, 2023

Awesome, that fixed it. Thanks for digging into that.

@itzg itzg merged commit 890cd55 into itzg:master Sep 2, 2023
1 check passed
@grantbruneau
Copy link
Contributor Author

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants