-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extraDeploy array #170
Conversation
…cts at deploytime Signed-off-by: Grant Bruneau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The lint build failure probably isn't related to your change, but I'm not sure yet why it fails with
|
Looks like there was an error downloading bedrock at that moment. Can we retry the lint? I confirmed that URL works. |
Had already re-run, but was waiting to try again today since it might have been a github workflow networking issue. |
Still failing in the same way. I really don't think it's related to your changes, so I'll experiment with a PR with no changes from master. |
Seems like it might be the github runner, has anything changed on that end? My googling says maybe firewall issue. Edit: Actually, this is all from within KIND, so maybe not runner specifically. |
[skip ci]
[skip ci]
[skip ci]
Updating kind and metallb
Hotfix/linter
Thanks! Running it now |
Awesome, that fixed it. Thanks for digging into that. |
Happy to help! |
Adds extraDeploy array which allows us to include additional objects at deployment. My reason for this is to use helm pre-install/post-delete hooks which can automatically add/remove DNS entries for my minecraft servers.
Reference