Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modlist files #3077

Open
cethien opened this issue Sep 21, 2024 · 2 comments
Open

Add Modlist files #3077

cethien opened this issue Sep 21, 2024 · 2 comments

Comments

@cethien
Copy link

cethien commented Sep 21, 2024

Enhancement Type

Improve an existing feature

Describe the enhancement

similar to DATAPACKS_FILE, a similar variable for auto downloaded mods may be nice.
DATAPACKS_FILE has the neat function that if changed, i dont have to compose up and down to apply, i can just restart the container. e.g. with MODRINTH_PROJECTS, i need to recompose the container / stack.

MODRINTH_PROJECTS_FILE would be nice, since its changeable like the datapack file

personal gripe: i use version control and have my modrinth stuff in a modrinth.env file. while fine since no secrets, including .env files in git always icks me a bit

@itzg
Copy link
Owner

itzg commented Sep 21, 2024

I'll look into this for a MODRINTH_PROJECTS_FILE.

I don't quite understand the problem though with re-running docker compose up to reapply the changes. You mention "stacks". Is it because you're using Portainer?

@cethien
Copy link
Author

cethien commented Sep 22, 2024

I don't quite understand the problem though with re-running docker compose up to reapply the changes.

reapplying docker compose up is not really a problem, its more of a annoyance since i also use the backup containers and a caddy container for bluemap, which sometimes also restarts for some reason. also sometimes the restart fails for no reason, but thats propably a docker problem on my end

basically, my request is more about keeping things a bit cleaner, so its not really high prio

You mention "stacks". Is it because you're using Portainer?

nah, i use docker swarm on some stuff, so stack just stick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants