Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand filtering of unit list #2

Open
itvbbjorn opened this issue Aug 11, 2023 · 4 comments
Open

Expand filtering of unit list #2

itvbbjorn opened this issue Aug 11, 2023 · 4 comments

Comments

@itvbbjorn
Copy link
Owner

It would be nice to be able to filter by era, PV etc when looking for units to add to the force. The list of names currently in the app was scraped from masterunitlist as a one time thing. As far as I know there's no API we can use to get a list of units with properties but maybe I've missed something.

@piotrberlowski
Copy link

piotrberlowski commented Aug 23, 2023

On this topic - I needed the filters and searches to look at units, so I wrote this react thingy: http://mul.berlowscy.pl/ - the code is here; https://github.com/piotrberlowski/mul-search - that actually gets a list of units with properties directly from MUL

Do you want to steal it all and add as your search perhaps? Or would you consider figuring out an api that I could call and add units to a roster in your app with some sort of "+" button on my results list?

@itvbbjorn
Copy link
Owner Author

This looks really cool. I'll take a more in depth look at it later to see if I can implement something similar. I feel like the biggest problem right now is figuring out a UI for it on a phone screen for the app.

@piotrberlowski
Copy link

In terms of cards display, I'd say you're in a good place. Search-wise, it's usable.

When it comes to the more complex search like mine - I think it works OK in landscape and pretty meh in portrait.

@piotrberlowski
Copy link

I integrated a UI based on your code into my search app. I hope that you're OK with the attribution here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants