🚑 access error for poses created for different companies #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itpp-bot
reviewed
Oct 31, 2019
There was a problem hiding this comment.
2 installable modules are updated:
├─ pos_longpolling/
| ├─ __manifest__.py
| ├─ doc/
| | └─ changelog.rst
| └─ static/
| └─ src/
| └─ js/
| └─ pos_longpolling.js
└─ pos_multi_session/
├─ __manifest__.py
├─ data/
| └─ pos_multi_session_data.xml
├─ demo/
| └─ demo.xml
├─ doc/
| └─ changelog.rst
├─ models/
| └─ pos_multi_session_models.py
├─ security/
| └─ ir_rule.xml
├─ static/
| └─ src/
| └─ js/
| └─ pos_multi_session.js
└─ views/
└─ pos_multi_session_views.xml
Not installable modules remain unchanged.
sent by ✌️ Odoo Review Bot
| -------- | ||
|
|
||
| - **Fix:** Access error for poses created for different companies | ||
|
|
KolushovAlexandr
force-pushed
the
11.0-pos_ms-wmc-compatibility
branch
from
1e40701 to
0d2c3fd
Compare
ilmir-k
reviewed
Nov 21, 2019
em230418
reviewed
Jan 10, 2020
| result = False | ||
| if 'multi_session_id' in vals: | ||
| multi_session_id = vals.get('multi_session_id') | ||
| if multi_session_id: |
There was a problem hiding this comment.
Я правильно понимаю, что multi_session_id может быть задан в словаре, но иметь значение вида 0, False или None? Меня тут смутило то, что мы сначала проверяем наличие multi_session_id, потом вызываем .get который не выкинет исключение, если его там нет.
There was a problem hiding this comment.
get по привычке наверное Саша написал.
yelizariev
approved these changes
Jul 3, 2020
| @@ -88,6 +88,29 @@ | |||
| </div> | |||
| </div> | |||
| </xpath> | |||
| <xpath expr="//field[@name='journal_id']/../../../../.." position="after"> | |||
There was a problem hiding this comment.
Попроще точно ничего нельзя сделать?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.