-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: useful reth / alloy type conversions #82
Labels
A-providers
Area: Providers crate
A-rollup
Area: rollup crate
C-blocked
A blocked issue
C-enhancement
New feature or request
Comments
merklefruit
added
C-enhancement
New feature or request
D-good-first-issue
Desc: Good for newcomers
A-providers
Area: Providers crate
A-rollup
Area: rollup crate
labels
Sep 5, 2024
@merklefruit let me try |
@merklefruit When I looked alloy, it did't depend on |
Yeah that's the issue. We can just wait to see if Reth is interested in using Alloy types for this and then it will be possible. |
merklefruit
added
C-blocked
A blocked issue
and removed
D-good-first-issue
Desc: Good for newcomers
labels
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-providers
Area: Providers crate
A-rollup
Area: rollup crate
C-blocked
A blocked issue
C-enhancement
New feature or request
The following traits should be implemented in alloy to remove manual casting functions in op-rs:
impl From<reth::primitives::SealedBlock> for alloy::rpc::types::Block
impl From<reth::primitives::SealedHeader> for alloy::consensus::Header
impl From<reth::primitives::TransactionSigned> for Option<alloy::consensus::TxEnvelope>
(TryFrom is fine too)impl From<reth::rpc::types::Block> for alloy::rpc::types::Block<TxEnvelope>
The text was updated successfully, but these errors were encountered: