-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use quantity for chainid key type #49
Comments
request ( |
ah sorry my issue was vague, I was referring to serde here
should serialize chainid keys as quantity (hex) |
Should be useful to add “blocked” issue label to the labels list and point here maybe |
it's not blocked, we can simply use |
It’s awaiting quantity hashmap from alloy to put serde attribute on |
No, |
Oh, yes, my fault :) |
this should serialize chainid as quantity (
U64
)odyssey/crates/wallet/src/lib.rs
Line 60 in bc8c87e
this could be made nicer if we had alloy-rs/alloy#1502
but for now we need to use the
alloy-primitives::U64
type here instead ofu64
TODO
U64
as the key typeThe text was updated successfully, but these errors were encountered: