Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong filename in template.njk if fontName and templateFontName configured #331

Open
emkayy opened this issue Jan 8, 2021 · 0 comments
Open

Comments

@emkayy
Copy link

emkayy commented Jan 8, 2021

If I have configured e.g.:

fontName: 'icons-a'
templateFontName: 'icons',

the file name of the font files will be 'icons-a.*'.
However, because of the line fontName: options.templateFontName || options.fontName, I only have the value of templateFontName as file name available in the nunjucks template. Thus the font files can never be found.

Could you please fix this issue as soon as possible since I'm relying on this feature and can't continue for my project.
You could just add an additional filename attribute or pass in the whole config object. This would allow for even greater flexibility since you could then add extra attributes to your template for further customization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant