Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafeDamage is not safe #223

Open
Lemonymous opened this issue Jul 28, 2024 · 0 comments
Open

SafeDamage is not safe #223

Lemonymous opened this issue Jul 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Lemonymous
Copy link
Contributor

Lemonymous commented Jul 28, 2024

SkillEffect.AddSafeDamage, SkillEffect.QueuedSafeDamage and Pawn.ApplyDamage are all broken, and are not safe to call to deal damage without potentially destroying terrain.

All of these functions are based on SkillEffect.AddSafeDamage.

SkillEffect.AddSafeDamage works by repairing destructible terrain after dealing the damage.

Cracked tiles was added with the Advanced Edition, which makes any terrain destructible. This is not taken into account with the safe damage function.

In order for these functions to work as advertised, they would have to be updated to account for cracked tiles in some way.

@Lemonymous Lemonymous added the bug Something isn't working label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant