Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pilots added in Advanced Edition do not have PilotPersonalities defined #172

Open
kartoFlane opened this issue Oct 1, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@kartoFlane
Copy link
Member

Dialogues for new pilots added in Advanced Edition are defined via the new translation system added in ITB 1.2 (localization/Pilots_ae.csv), and do not get processed by personalities/personalities.lua script. Because of this, these new pilots do not have corresponding PilotPersonality instances in the global lua scope. This makes it difficult to add/modify dialogues for these pilots using existing methods.

In this discord message, tosx simply created new global instances for the new AE pilots, and that seems to work, since the game falls back on the old, deprecated texts system when it cannot find a matching text.

Long term, we should probably add a modApi function to add dialogue lines like this.

@kartoFlane kartoFlane added the bug Something isn't working label Oct 1, 2022
@KnightMiner
Copy link
Member

What prevents us from just adding dialogue using modApi:setText? Could always write a loop to create text with the proper keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants