Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected squads cause vanilla achievements to look buggy #168

Open
KnightMiner opened this issue Sep 23, 2022 · 2 comments
Open

Selected squads cause vanilla achievements to look buggy #168

KnightMiner opened this issue Sep 23, 2022 · 2 comments
Labels
blocked This can't be worked on for now bug Something isn't working

Comments

@KnightMiner
Copy link
Member

Due to how selected squads work, vanilla achievements show the wrong title and tooltip, but the correct icons:

image

We should detect when the achievements menu opens and undo our title override/tooltip override. When paired with #167, this will ensure all achievements are visible.

@KnightMiner KnightMiner added the bug Something isn't working label Sep 23, 2022
@Lemonymous
Copy link
Contributor

detect-achievement-tabs

I am having difficulty identifying when the two different tabs are open. It appears to me that the same text is used for both the button and the title.

Hangar_Achievements_Title = "Achievements"
Button_MainSquads = "Squads"
Ach_Global = "Global"

Until someone can find a way to detect when either is open, this issue is blocked.

@Lemonymous Lemonymous added the blocked This can't be worked on for now label Oct 7, 2022
@KnightMiner
Copy link
Member Author

KnightMiner commented Oct 7, 2022

We could honestly just detect when either is open, its not a huge deal if we are on the global achievements page and we disable our overrides. That said, it will make #167 more difficult to handle if we cannot tell which is which

So perhaps just have an achievements UI open event/getter, and if that getter returns true, skip the title overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This can't be worked on for now bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants