Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit modloader added functions to make sure none are redundant to new built in functions #159

Open
KnightMiner opened this issue Aug 26, 2022 · 4 comments
Labels
cleanup Issues and pull requests related to improving the codebase without direct functional changes

Comments

@KnightMiner
Copy link
Member

Between the 1.2 update and the Advanced Edition update, quite a few new functions have been added to the game. Now would be a good time to go through all the functions the modloader adds to verify two things:

  • Verify that none of the functions we add have the same name as a new built in function. If so, either rename or remove them
  • Verify that none of the functions we add do the same thing as a new built in function. If so, redirect the behavior to the built in logic where possible.

Would be worth doing this to modApiExt afterwards as well.

@KnightMiner KnightMiner added the cleanup Issues and pull requests related to improving the codebase without direct functional changes label Aug 26, 2022
@KnightMiner
Copy link
Member Author

Some things found at a quick search:

  • Board:SetShield: should internally call AddShield and RemoveShield
  • Pawn:IsPowered: vanilla function exists by the same name, should check if it has the same behavior

Some things that are not the same

  • IsMutation is not usable in place of Board:IsMutation, Matthew said on discord it is related to scrapped content rather than psions.

@KnightMiner
Copy link
Member Author

As another note, it looks like we have three skill effect functions that should likely be supported for the extra queued options:

  • AddBurrow
  • AddTeleport
  • AddReverseAirstrike

Need to test if all of them work as queued attacks, I highly suspect AddReverseAirstrike will, but not sure on the other two

@Lemonymous
Copy link
Contributor

PR #165 addresses Board:SetShield and Pawn:IsPowered, though I have not looked into Board:IsMutation

@KnightMiner
Copy link
Member Author

KnightMiner commented Sep 20, 2022

No work is needed for Board:IsMutation, that was a comment saying that IsMutation is not the same and does not need to be considered.

71800fe deals with Pawn:IsPowered, since ours was broken and vanilla exists might as well use the vanilla one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Issues and pull requests related to improving the codebase without direct functional changes
Projects
None yet
Development

No branches or pull requests

2 participants