Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Pre-add items to arrays fields when they are mandatory. #116

Open
wants to merge 1 commit into
base: legacy
Choose a base branch
from
Open

WIP: Pre-add items to arrays fields when they are mandatory. #116

wants to merge 1 commit into from

Conversation

bfabio
Copy link
Member

@bfabio bfabio commented Nov 15, 2019

Fix #108

@libremente
Copy link
Member

libremente commented Feb 4, 2020 •
edited
Loading

Hi @bfabio and thanks for the PR! This looks OK, however the test needs to be updated. Could you change the

publiccode-editor/src/test/rf.test.js

Line 64 in f68f2d1

expect(inputs.length).toBe(54);
to be 55? That would make the test pass and we can merge this PR! Thanks a lot!

@bfabio
Copy link
Member Author

bfabio commented Feb 5, 2020

Hey @libremente, done.

I originally left the PR as WIP because it kinda breaks apart in the maintenance section:

  1. While it correctly adds the "Contacts" or "Contractors" form when maintenanceType changes, it doesn't remove them yet when maintenanceType changes again.
  2. The close button is still present, albeit not functional, when it shouldn't be; for example on the first Contractor subform when maintenanceType is "contract".

Since the bug is marked as "good first issue" I was trying to bait new contributors lurking (hi!) the bug reports to pick it up where I left off 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required array of string fields should be prepopulated with the first item
2 participants
@bfabio @libremente