Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow major isotope fractional abundance in an isotope system #3

Open
sebkopf opened this issue Apr 17, 2014 · 0 comments
Open

allow major isotope fractional abundance in an isotope system #3

sebkopf opened this issue Apr 17, 2014 · 0 comments

Comments

@sebkopf
Copy link
Collaborator

sebkopf commented Apr 17, 2014

allow having the major isotope fractional abundance listed in an isotope system but make sure it is treated approriately
--> if present, this changes the abundance to ratio conversion!
--> also think about what might happen with the rowsum ! > 1 validation constraints in case machine error is so close to 1 (but still above) if all fractional abundance including major isotope is specified
--> should there be a constraint that imposes if the major isotope is specified, all columns MUST add up to 1?
--> perhaps instead allow (include_major = F/T) as a parameter in the abundance() function which will then automatically add this one after the isotope system is initialized (and can be added again easily if an isotope system converted from say ratio is backconverted to abundance, by recasting with the abundance(..., include_major = F/T) function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant