Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make iso_mark_calibration_range work with x/y variable renames #69

Open
sebkopf opened this issue Nov 21, 2019 · 0 comments
Open

make iso_mark_calibration_range work with x/y variable renames #69

sebkopf opened this issue Nov 21, 2019 · 0 comments

Comments

@sebkopf
Copy link
Contributor

sebkopf commented Nov 21, 2019

if a y or x value is renamed during iso_plot_data, then iso_mark_calibration_range will no longer recognize the range constraint anymore and it needs to be possible to tell the function which variable is actually which

one way to potential remedy this in a more autmoted way is to have all transformations that are applied to x and y during iso_plot_data ALSO applied to the calibration ranges that are stored inside the data frame! this is probably easiest if first nesting the dataset based on all calib_params fields (from all calibrations) and then doing the modifications in each evaluation ranges (keeping the original var names and ranges and adding the additional ones based on rename / mutate statements)

@sebkopf sebkopf changed the title provide ways to indicate renames in iso_mark_calibration_range make iso_mark_calibration_range work with x/y variable renames Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant