Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.83.0 #1860

Merged
merged 24 commits into from
Mar 21, 2024
Merged

release v0.83.0 #1860

merged 24 commits into from
Mar 21, 2024

Conversation

seaerchin
Copy link
Contributor

New

  • Test/repo privatisation #1342
  • fix(resourceModal): sane default permalink #1858
  • fix(routeselector/resourceroom): remove accidental comments + fix typo #1859
  • chore(validation): add validation for all routes #1854
  • fix(permalinks): default permalink for create #1843
  • feat(tiptap): add supersub #1855
  • fix(app): change service to isomer #1857
  • fix(accordion): styles #1834
  • fet(admin): add release prep script #1853
  • feat(playwright): migrate #1805
  • feat(editpage): add resource spec, remove cypress spec #1796
  • feat(editpage): add collection page tests #1795
  • feat(e2e): migrate unlinked page tests to playwright #1790
  • feat(playwright): migrate dashboard spec #1789
  • build(package-lock): bump pm to 2.0.8 to avoid legal #1833
  • backport v0.82.0 #1846

Dependencies

  • chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 #1849
  • chore(deps): bump react-select from 5.7.4 to 5.8.0 #1847
  • chore(deps): bump the npm_and_yarn group group with 2 updates #1842

Dev-Dependencies

  • chore(deps-dev): bump browserify-sign from 4.2.1 to 4.2.3 #1836
  • chore(deps-dev): bump @adobe/css-tools from 4.2.0 to 4.3.3 #1837
  • chore(deps-dev): bump @storybook/addon-actions from 7.1.1 to 8.0.0 #1841

Tests

fix(resourceModal): sane default permalink #1858

follow video

Screen.Recording.2024-03-19.at.6.18.15.PM.mov
  • create a resource page, note that you should be unable to modify the permalink
  • edit resource page modal's functionality remains the same, we dont still allow them to change to whatever.

fix(permalinks): default permalink for create #1843

follow video

Screen.Recording.2024-03-14.at.3.15.06.PM.mov
  • create a page, note that you should be unable to modify the permalink
  • edit page modal's functionality remains the same, we dont still allow them to change to whatever.

feat(playwright): migrate #1805

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests

Deploy Notes

feat(playwright): migrate #1805

New environment variables:

  • env var : env var details

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

Full Changelog: https://github.com/isomerpages/isomercms-frontend/compare/v0.82.0..v0.83.0

dcshzj and others added 22 commits March 14, 2024 16:13
Bumps [react-select](https://github.com/JedWatson/react-select) from 5.7.4 to 5.8.0.
- [Release notes](https://github.com/JedWatson/react-select/releases)
- [Changelog](https://github.com/JedWatson/react-select/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/JedWatson/react-select/compare/[email protected]@5.8.0)

---
updated-dependencies:
- dependency-name: react-select
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/35a517c5861d79dc8bff7db8626013d20b711b06"><code>35a517c</code></a> Release version 1.15.6 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/c4f847f85176991f95ab9c88af63b1294de8649b"><code>c4f847f</code></a> Drop Proxy-Authorization across hosts.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/8526b4a1b2ab3a2e4044299377df623a661caa76"><code>8526b4a</code></a> Use GitHub for disclosure.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/b1677ce00110ee50dc5da576751d39b281fc4944"><code>b1677ce</code></a> Release version 1.15.5 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/d8914f7982403ea096b39bd594a00ee9d3b7e224"><code>d8914f7</code></a> Preserve fragment in responseUrl.</li>
<li>See full diff in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.15.4...v1.15.6">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=follow-redirects&package-manager=npm_and_yarn&previous-version=1.15.4&new-version=1.15.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/isomerpages/isomercms-frontend/network/alerts).

</details>
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.3.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.3.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.3)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(playwright): initial scaffold

* feat(fixtures): add fixtures for playwright

* build(package): update deps

* feat(dashboard): add new spec in playwright

* feat(tsconfig): add tsconfig

* refactor(constants): removed extra file

* refactor(const): update to export from hook

* style(dashboard.spec): remove async

* fix(tsconfig): use extends

* fix(playwirght-script): reset e2e prior to run
* feat(editpage): add spec for unlinked pages

* refactor(editpage): remove cypress specs that got migrated

* docs(editpage): reload + add TODO
* feat(editpage-spec): add collection page tests

* refactor(cypress): delete replaced spec
## Problem

Design review for accordions, addressing changes [here](https://www.notion.so/opengov/Accordion-design-QA-7a07a952d7514f6989e8d04f61c1fac8?pvs=4).

## Solution

Fix styling issues
* feat(super/sub): add super/sub scripts

* feat(assetse): add super/sub

* feat(menubar): add super/sub
## Problem

We have quite a number of duplicate permalinks
this does not fix the problem completely, but it does allow for some sort of preventive measure to prevents accidental dups. 

we are not sure if of the number of agencies that use dup permalinks for the sake of playground, and it would be hard to enforce this until we have the functionality for playground out. more context [here](https://opengovproducts.slack.com/archives/CK68JNFHR/p1710317487152189)


## Solution

sane default when creating a page.

**Breaking Changes**

<!-- Does this PR contain any backward incompatible changes? If so, what are they and should there be special considerations for release? -->

- [ ] Yes - this PR contains breaking changes
  - Details ...
- [X] No - this PR is backwards compatible with ALL of the following feature flags in this [doc](https://www.notion.so/opengov/Existing-feature-flags-518ad2cdc325420893a105e88c432be5)


## Tests

follow video

https://github.com/isomerpages/isomercms-frontend/assets/42832651/3c3657dc-b9a1-4a40-9e49-07d71c32fd0a

- [ ] create a page, note that you should be unable to modify the permalink 
- [ ] edit page modal's functionality remains the same, we dont still allow them to change to whatever.
* fix(resourceroom): strengthen validation

* fix(routeselector): update rr name + collection name regex

* fix(validation): add stronger validation

* fix(validation): fix validation

* fix(routeselector): remove extra comment
#1859)

* fix(routeselector/resourceroom): remove accidental comments + fix typo

* fix(routeselector): validate tou

* fix(validators): add new regex

* test(routeselector): remove old check + fix tests
## Problem

same as #1843 but for resource pages 


## Tests
follow video


https://github.com/isomerpages/isomercms-frontend/assets/42832651/f545f927-90ba-4daf-a555-62f5b1a834f7

- [ ] create a resource page, note that you should be unable to modify the permalink 
- [ ] edit resource page modal's functionality remains the same, we dont still allow them to change to whatever.
* chore: update settings fixture to use email login

* feat: add privatisation test to settings e2e

* chore: revert changes to before step and skip privatisation tests
@seaerchin seaerchin requested a review from a team March 21, 2024 06:39
@seaerchin seaerchin mentioned this pull request Mar 21, 2024
@seaerchin
Copy link
Contributor Author

seaerchin commented Mar 21, 2024

@dcshzj

Tests

NOTE: refer to this doc for special chars

Sitename/resource name/collection

  • ensure that you cannot create any of these with a special character
  • create one of these (less sitename) with a space + a dash
  • ensure that you can access them (note that hte url converts space to a dash)

filename

  • create a filename with the allowed special characters (given in the doc)
  • create a filename w/ chi/tamil characters (non-ascii)
  • ensure that you can access those pages

sub-collection + resource category

  • ensure that you cannot create a sub-collection with teh disallowed special characters
  • create a sub-collection with the allowed special characters (see doc) + ensure that the sub-collection has a dash + a space
  • ensure that you can access said sub-collection

media
note that for media stuff, we can create nested folders and these folders are encoded using %2f

  • ensure that you cannot create a media folder with teh disallowed special characters
  • ensure that you can create a media folder with the allowed special characters
  • ensure that you can upload images/files with special characters and that the special characters are renamed to _
  • ensure that you can rename the images/files to allowed special characters
  • ensure that you cannot rename the images/files to disallowed special characters

@seaerchin
Copy link
Contributor Author

seaerchin commented Mar 21, 2024

@dcshzj

Manual tests

  • add some text onto the page
  • select the text
  • click teh superscript icon
  • text should now be superscript
  • reload the page
  • changes should be persisted
  • repeat the above but for subscript

Copy link

mergify bot commented Mar 21, 2024

⚠️ The sha of the head commit of this PR conflicts with #1861. Mergify cannot evaluate rules on this PR. ⚠️

@seaerchin seaerchin merged commit 82f1e79 into master Mar 21, 2024
16 of 17 checks passed
@seaerchin seaerchin deleted the release_v0.83.0 branch March 21, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants