Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resourceModal): sane default permalink #1858

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(resourceModal): sane default permalink #1858

merged 1 commit into from
Mar 21, 2024

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Mar 19, 2024 •
edited
Loading

Problem

same as #1843 but for resource pages

Tests

follow video

Screen.Recording.2024-03-19.at.6.18.15.PM.mov
  • create a resource page, note that you should be unable to modify the permalink
  • edit resource page modal's functionality remains the same, we dont still allow them to change to whatever.

@kishore03109 kishore03109 mentioned this pull request Mar 19, 2024
Merged
4 tasks
@kishore03109 Graphite App
Copy link
Contributor Author

kishore03109 commented Mar 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kishore03109 and the rest of your teammates on Graphite Graphite

@kishore03109 kishore03109 marked this pull request as ready for review March 19, 2024 10:21
@kishore03109 kishore03109 requested a review from a team March 19, 2024 10:21
seaerchin
seaerchin approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. your base branch is wrong btw so remember to change

Base automatically changed from 03-14-fix_permalinks_default_permalink_for_create to develop March 21, 2024 05:49
@kishore03109 kishore03109 force-pushed the 03-19-fix_resourceModal_sane_default_permalink branch from bfe1d4a to 7e094c2 Compare March 21, 2024 05:49
@kishore03109 Graphite App
Copy link
Contributor Author

Merge activity

  • Mar 21, 1:50 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@kishore03109 kishore03109 merged commit fb24a20 into develop Mar 21, 2024
5 checks passed
@mergify mergify bot deleted the 03-19-fix_resourceModal_sane_default_permalink branch March 21, 2024 05:51
@seaerchin seaerchin mentioned this pull request Mar 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore03109 @seaerchin