Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tiptap): add supersub #1855

Merged
merged 3 commits into from
Mar 19, 2024
Merged

feat(tiptap): add supersub #1855

merged 3 commits into from
Mar 19, 2024

Conversation

seaerchin
Copy link
Contributor

Problem

(yes i had to add that lame joke)
At present, nlb uses super/sub scripts to add anchor links. This PR adds a first pass of super/subscripts to our editor.

Closes [ISOM-793]

Solution

  • add tiptap super/subscript packages
  • add menu bar
  • toggle using menubar

Videos

Screen.Recording.2024-03-18.at.5.59.26.PM.mov

Manual tests

  • add some text onto the page
  • select the text
  • click teh superscript icon
  • text should now be superscript
  • reload the page
  • changes should be persisted
  • repeat the above but for subscript

@sehyunidaaa
Copy link
Contributor

@seaerchin
Seems to be working well! Can help me check these two behaviours as well?

  • Can you add a hyperlink to the superscript/subscripted text?
  • Do the sup/sub options in toolbar have tooltips? If yes, are the tooltips properly formatted ("Subscript", "Superscript")?

@seaerchin
Copy link
Contributor Author

@seaerchin Seems to be working well! Can help me check these two behaviours as well?

  • Can you add a hyperlink to the superscript/subscripted text?
  • Do the sup/sub options in toolbar have tooltips? If yes, are the tooltips properly formatted ("Subscript", "Superscript")?

yes to both!

@sehyunidaaa
Copy link
Contributor

thanku lgtm~ @seaerchin

@seaerchin seaerchin merged commit c09da76 into develop Mar 19, 2024
12 checks passed
@seaerchin seaerchin deleted the feat/super-sub branch March 19, 2024 10:07
@seaerchin seaerchin mentioned this pull request Mar 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants