chore(validation): add validation for all routes #1854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some of our routes don't have validation - this leads to security vulnerabilities where path traversal attacks can be done.
Solution
Validate routes based on teh following criteria (observed behaviour):
-
in the url so it's ok if we validate alphanumeric +-
. do note that non-ascii characters (chi/tamil) might have issues....
)/
(encoded) so we have to split and validate each one separately .___.Tests
NOTE: refer to this doc for special chars
Sitename/resource name/collection
filename
sub-collection + resource category
media
note that for media stuff, we can create nested folders and these folders are encoded using
%2f
_