Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE: Identity] Visual feedback when disabling RR creation #1159

Open
seaerchin opened this issue Nov 21, 2022 · 1 comment
Open

[FEATURE: Identity] Visual feedback when disabling RR creation #1159

seaerchin opened this issue Nov 21, 2022 · 1 comment

Comments

@seaerchin
Copy link
Contributor

Problem

at present, we have no visual feedback for users when rr creation is disabled due to no file changes. this might lead to confusion on the end of the users as they might not immediately know why.

Solution

Add in some form of visual feedback when rr creation is disabled. At present, this will be a tooltip saying Please ensure you have file changes and filled in required fields.

fyi @NatMaeTan, tracking issue - lmk when you have mocks

@NatMaeTan
Copy link
Contributor

No mocks, but disable the ["Request a review" button in the workspace] (https://www.figma.com/file/7OtNYkc4s9BkFk05ConEbd/%E2%AD%90-V1.5?node-id=4456%3A117533&t=DMilCGWJ0gOZ5rYX-1) , and NOT the submit button when creating an RR. Tooltip on hover can say "There are no new changes to publish."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants