Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile managment #21

Closed
dolik-rce opened this issue Feb 9, 2024 · 2 comments
Closed

Profile managment #21

dolik-rce opened this issue Feb 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dolik-rce
Copy link
Contributor

I have noticed that the profile names are take from two different sources:

  • The settings dialog displays the profiles names based on the filename
  • The title bar displays value of "Name" field in the configuration file.

There should be only one source of truth for this information.

How did I found this? I wanted to duplicate a profile, because I only needed to change the command and keep everything else same. Since the UI doesn't support that yet, I just went to the config directory and made a copy of the profile. After some time, I noticed that the title bar still shows the original name.

Also, the work with profiles could use some more features:

  • duplication (to create similar profile, as it happened to me)
  • rename (sometimes you need to change the name, to distinguish similar profile, or to unify the naming scheme)
  • ordering (to keep related profiles near each other)

Regarding the last point: I'm not 100% sure, but I think the order sometimes randomly changes, perhaps depending in which order are the files listed on the filesystem?

I think I will have some free time next week, so I can try to actually contribute some code, if you don't mind. It'd be fun to write something in U++ after so many years of using other languages :-)

@ismail-yilmaz
Copy link
Owner

ismail-yilmaz commented Feb 10, 2024

I think I will have some free time next week, so I can try to actually contribute some code, if you don't mind. It'd be fun to write something in U++ after so many years of using other languages :-)

Why of course! Please, "hop in" :).

I am planning some improvements for profile management. For one, I think it will be better if we move to a UID based approach (instead of using plain file names - that was a result of my laziness anyway) for profiles. Names should be optional and not be used as identifiers.

@ismail-yilmaz ismail-yilmaz added the enhancement New feature or request label Feb 17, 2024
@ismail-yilmaz
Copy link
Owner

I am closing this issue as fixed. However, I'll open a separate issue (#27) to improve profile management further. We can discuss, prioritize and turn them to tasks there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants