Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup pipeline and bin directory #96

Open
1 task
ismael-mendoza opened this issue Apr 3, 2022 · 0 comments
Open
1 task

cleanup pipeline and bin directory #96

ismael-mendoza opened this issue Apr 3, 2022 · 0 comments
Assignees
Labels

Comments

@ismael-mendoza
Copy link
Owner

ismael-mendoza commented Apr 3, 2022

Following #96 we should also cleanup the pipeline to generate data. This might enable processing other sims in the future and make the input of the data generation clearer which could prevent bugs.

I propose getting rid of click (or using barebones parts of it, not the ctx object) and instead use a yaml config files (parsed with omegaconf).

For the rest of the bin directory we could have different yaml files (or a yaml file with a bunch of options) to avoid hard coding default values.

  • avoid hard-coding paths make relative to repo.
@ismael-mendoza ismael-mendoza self-assigned this Apr 3, 2022
@ismael-mendoza ismael-mendoza changed the title cleanup pipeline cleanup pipeline and bin directory Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant