Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove builders #67

Open
berquist opened this issue Oct 8, 2019 · 1 comment · May be fixed by #68
Open

Remove builders #67

berquist opened this issue Oct 8, 2019 · 1 comment · May be fixed by #68
Assignees
@berquist
Labels
priority-2-low size-large student

Comments

@berquist
Copy link
Member

berquist commented Oct 8, 2019

and switch to using module-level private constructors.
@berquist berquist self-assigned this Oct 8, 2019
@berquist
Copy link
Member Author

berquist commented Oct 8, 2019

This will take a fair amount of work because of builder usage in vistautils and VistaNLP, as well as implementing efficient replacements for

immutablecollections/immutablecollections/_immutabledict.py

Line 166 in fc17708

def modified_copy_builder(self) -> "ImmutableDict.Builder[KT, VT]":

@berquist berquist linked a pull request Oct 8, 2019 that will close this issue
Draft
1 task
@gabbard gabbard added the student label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berquist berquist

Labels
priority-2-low size-large student
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove builders isi-vista/immutablecollections
2 participants
@berquist @gabbard