From dd82bf78635e9b9ca99df23eb45d3c3b8321c04a Mon Sep 17 00:00:00 2001 From: Scott Parkhill Date: Thu, 30 Mar 2023 11:32:13 -0400 Subject: [PATCH] Fix forgotten interface declaration change (#62) * Fix application breaking on js interop error Instead, it now catches the exception and stops tracking the connection. * Change method signature for async method without await * Remove unnecessary calls to base class initialization * Remove unsubscription from initialization method * Implement IDisposable and have unsubscribe occur there * Change from OnInitializedAsync to OnIntialized * Change IAnalytics interface for ConfigureGlobalEventData to be synchronous * Remove accidental async addition in interface --- src/Blazor.Analytics/Abstractions/IAnalytics.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Blazor.Analytics/Abstractions/IAnalytics.cs b/src/Blazor.Analytics/Abstractions/IAnalytics.cs index f9e34e2..952e164 100644 --- a/src/Blazor.Analytics/Abstractions/IAnalytics.cs +++ b/src/Blazor.Analytics/Abstractions/IAnalytics.cs @@ -6,7 +6,7 @@ namespace Blazor.Analytics public interface IAnalytics { Task ConfigureGlobalConfigData(Dictionary globalConfigData); - Task ConfigureGlobalEventData(Dictionary globalEventData); + void ConfigureGlobalEventData(Dictionary globalEventData); Task TrackNavigation(string uri);