Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify "tuning" attribute in database to correspond to a valid tuning as interpreted by the tabbing algorithm #58

Open
jalfje opened this issue Jul 19, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jalfje
Copy link
Collaborator

jalfje commented Jul 19, 2020

At present, the tabbing algorithm can take tuning into account; however, it doesn't actually use the tuning value stored in the database. This should be fixed. To do so, the tuning attribute could be stored as a 6-element array (more difficult, and would wind up require re-translating into a standard tuning on the frontend), or as a string. The string could either be a preset value (e.g. "Standard", "Drop D", "Open G", which would require translating before tabbing, but this translation would be well-defined), a sequence of MIDI notes (e.g. "64 59 55 50 45 40", which would require translating before being displayed on the frontend), or a sequence of character notes (e.g. "E B G D A E", which would require translating before tabbing, and this translation would have to be estimated based differential from standard tuning, i.e. assuming that no string is tuned more than 5 half-steps away).

@jalfje jalfje added the bug Something isn't working label Jul 19, 2020
@jalfje jalfje self-assigned this Jul 19, 2020
@isaaccormack
Copy link
Owner

Nice! Glad the backend can take into account tuning like that. I think the assumption that no string is tuned more than 5 half-steps away is totally reasonable.

I can have a go at implementing this when feature/refactor-tabbing is good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants