Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson 33 sample html out of date #7

Open
manuelsidler opened this issue Oct 24, 2019 · 0 comments
Open

Lesson 33 sample html out of date #7

manuelsidler opened this issue Oct 24, 2019 · 0 comments

Comments

@manuelsidler
Copy link

In lesson 33 you provide a sample html of the JSON.NET NuGet package site. It seems like the NuGet team has removed the this version indicator from their sites now.

Sample HTML
image

Live Site
image

Therefore the parsing logic to indicate the current version in your sample solution doesn't work anymore.

First solution that comes to my mind: get highest version where version string doesn't contain any dashes (eg 1.0.0.1, 2.5.8, 12.3, 16).

Second solution: use the HTML provider and check for the bg-info css class (which seems to indicate the current version on their site now):
image

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant