Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add replace_cylinders_with_capsules option in Urdf converters #1430

Open
1 task done
ZiwenZhuang opened this issue Nov 18, 2024 · 1 comment
Open
1 task done
Labels
enhancement New feature or request

Comments

@ZiwenZhuang
Copy link

Proposal

Adding replace_cylinders_with_capsules in the urdf converters configuration class.

Motivation

Previously in IsaacGym/legged_gym, replace_cylinders_with_capsules option can make the simulation faster and more stable. However, when radius is a lot greater than cylinders' length, the collision shape will be extremely different.

Please consider adding this option in the implementation of _get_urdf_import_config

Additional context

I've checked that this does not need any other implementations, just adding two lines of code.

  1. In _get_urdf_import_config of UrdfConverter in omni.isaac.lab/omni/Isaac/lab/sim/converters/urdf_converters.py
截屏2024-11-18 14 24 17
  1. In UrdfConverterCfg in omni.isaac.lab/omni/Isaac/lab/sim/converters/urdf_converters_cfg.py
截屏2024-11-18 14 23 36

Checklist

  • I have checked that there is no similar issue in the repo (required)
@RandomOakForest
Copy link
Collaborator

Thank you for posting this. The team will review as a possible enhancement in an upcoming release.

@RandomOakForest RandomOakForest added the enhancement New feature or request label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants