Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dragging over tokens causes "infinity" distance and red warning #131

Open
ctbritt opened this issue Mar 2, 2023 · 6 comments
Open

Comments

@ctbritt
Copy link

ctbritt commented Mar 2, 2023

Describe the bug
Dragging a token over another token with "Include Live/Dead Tokens" selected in settings results in a red warning square and an "infinity" distance.

To Reproduce
Steps to reproduce the behavior:

  1. Drag a token over another token
  2. Watch the red warnings appear.

Expected behavior
Token should count the intervening token as difficult terrain and double the movement cost.

Screenshots
CleanShot 2023-03-02 at 17 27 11

Please complete as much of the following information as possible:

  • Browser Version 110.0.5481.177 (Official Build) (arm64)
  • Foundry Version 10.291
  • System DnD 2.1.5
  • Module version 10.6
  • Are there any errors in the console No
  • Have you tried using Find the Culprit to make sure it isn't a module interaction. Yes. Does not seem to be module interaction.

Additional context
Add any other context about the problem here.

@ctbritt
Copy link
Author

ctbritt commented Mar 2, 2023

Addendum. Seems to be a conflict with DnD5e Drag Ruler Integration

@jputman
Copy link

jputman commented Apr 22, 2023

Agreed that I have been seeing this issue, and can confirm that disabling the Token Difficult Terrain check in DnD5e Drag Ruler Integration resolves the issue. But it seems to only impact hostile creatures. Neutral and Friendly seem to calculate properly.

@davelacorneille
Copy link

Same for me.

@ctbritt
Copy link
Author

ctbritt commented May 18, 2023

Have fixed this. Set the Rule Provider setting in Enhanced Terrain Layer to Built-In. Also set Include Live/Dead Tokens settings to Any... Then, in the D&D Drag Ruler Integration setting, set Token Difficult Terrain to true. This fixed the "infinity" issue for me.

@ironmonk88
Copy link
Owner

So, this isn't an Enhanced Terrain Issue. And... I'm not actually sure it's an issue per say.
The Rule Provider from the ruler is returning Infinity because it's saying, due to rules, you can't walk through that square.
Drag Ruler isn't showing this information very well.

So if you think the token should be able to walk through the square, and the ruler is saying you can't, then it's an issue with the ruler module.
But also, Drag Ruler should have a ticket opened to maybe change "Infinity" to "∞" for better readability.

@jputman
Copy link

jputman commented May 27, 2023

I think the mechanics issue is that the token is marked dead and thus should only be difficult terrain and not blocking terrain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants