Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

tests failing #3

Open
kessler opened this issue Aug 31, 2018 · 3 comments · Fixed by #4
Open

tests failing #3

kessler opened this issue Aug 31, 2018 · 3 comments · Fixed by #4
Assignees

Comments

@kessler
Copy link
Member

kessler commented Aug 31, 2018

ok 1 should be equal
# failing
not ok 2 should be equal
  ---
    operator: equal
    expected: |-
      'TAP version 13\n# ok1\nok 1 test 1\n# fail1\nnot ok 2 should be equal\n  ---\n    operator: equal\n    expected: 3\n    actual: 2\n    at: \'Test.fail1 (node-multi-tap/test/basic/fail1.js:2:5)\'\n  ...\n\n1..2\n# tests 2\n# pass  1\n# fail  1'
    actual: |-
      'TAP version 13\n# ok1\nok 1 test 1\n# fail1\nnot ok 2 should be equal\n  ---\n    operator: equal\n    expected: 3\n    actual: 2\n    at: >-\n      Test.fail1\n      (node-multi-tap/test/basic/fail1.js:2:5)\n  ...\n\n1..2\n# tests 2\n# pass  1\n# fail  1'
    at: ConcatStream.<anonymous> (node-multi-tap/node_modules/concat-stream/index.js:36:43)
  ...

Vincent could you take a look? just trying to publish a version with up to date debug module

@kessler kessler changed the title tests failed tests failing Aug 31, 2018
@vweevers
Copy link
Collaborator

Reproduced, having a look.

@vweevers vweevers mentioned this issue Aug 31, 2018
@kessler kessler closed this as completed in #4 Sep 2, 2018
@kessler kessler reopened this Sep 2, 2018
@kessler
Copy link
Member Author

kessler commented Sep 2, 2018

Sorry but I accidentally approved this PR instead of trying the branch first, this is what I got:

# failing
not ok 2 should be equal
  ---
    operator: equal
    expected: |-
      'TAP version 13\n# ok1\nok 1 test 1\n# fail1\nnot ok 2 should be equal\n  ---\n    operator: equal\n    expected: 3\n    actual: 2\n    at: \'Test.fail1 (/Users/kessler/dev/ironsrc/opensource/node-multi-tap/test/basic/fail1.js:2:5)\'\n  ...\n\n1..2\n# tests 2\n# pass  1\n# fail  1'
    actual: |-
      'TAP version 13\n# ok1\nok 1 test 1\n# fail1\nnot ok 2 should be equal\n  ---\n    operator: equal\n    expected: 3\n    actual: 2\n    at: >-\n      Test.fail1\n      (/Users/kessler/dev/ironsrc/opensource/node-multi-tap/test/basic/fail1.js:2:5)\n  ...\n\n1..2\n# tests 2\n# pass  1\n# fail  1'
    at: ConcatStream.<anonymous> (/Users/kessler/dev/ironsrc/opensource/node-multi-tap/node_modules/concat-stream/index.js:36:43)
  ...

@vweevers
Copy link
Collaborator

vweevers commented Sep 2, 2018

Which node version?

I'll take another look later. The bug is in the tests, not the implementation, so no rush.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants