Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code structuring in general #71

Open
irisfofs opened this issue Jan 29, 2016 · 0 comments
Open

Improve code structuring in general #71

irisfofs opened this issue Jan 29, 2016 · 0 comments
Assignees
@irisfofs
Labels
enhancement Tracking
Milestone
v0.5.1

Comments

@irisfofs
Copy link
Owner

My code is not as great as it could be (as evidenced by that nice 1.6 'GPA').

Stuff under the chopping block:
@irisfofs irisfofs self-assigned this Jan 29, 2016
@irisfofs irisfofs added this to the v0.5.1 milestone Jan 29, 2016
irisfofs added a commit that referenced this issue Jan 31, 2016
@irisfofs
Improve TagImplicationHandler methods
0aea4db 
Added a helper method to replace the duplicate looping behavior in both
implicate_tags and alias_tags.

Moved the failure message for cyclical tags to its own method, and made
alias_tags call it directly instead of throwing back to update_tags.

This is part of work on #71.
irisfofs added a commit that referenced this issue Feb 5, 2016
@irisfofs
Commented + small refactor of Tag class
c269c65 
Just little improvements for readability and documentation, in the
spirit of #71.
irisfofs added a commit that referenced this issue Feb 5, 2016
@irisfofs
Refactor Tag#<=> to be less complicated
1b3f870 
Previously, it was tripping basically every complexity warning possible.
Now... well, it is less branching, at least in terms of if/elsif/else
statements. I think this is also decently intuitive.

The Tag file now has no warnings from Rubocop. Woo, #71!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irisfofs irisfofs

Labels
enhancement Tracking
Projects
None yet
Milestone
v0.5.1
Development

No branches or pull requests
1 participant
@irisfofs