-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RP formatting to Liquid templates #57
Comments
In preparation for working on #57, I set up a couple tests that look at the output of rendering a page. This'll be useful.
So this revealed that using Liquid to generate the RP pages is actually really, really slow. Much slower than generating it with Ruby, the previous approach. It's more expressive and is actually user-editable, but it seems like it might not be worth it. Reopening this to have the changes moved into their own feature branch, to be potentially readded later. |
Jekyll 3.1 renders it in around 60% of the time, but it's still very slow. |
Here's some rough timing, using some "representative sample data" (the collection of 138 RPs currently on my own site):
Also note that using Jekyll v3.1 is currently not supported (see #66). So the options are keep the current, slightly icky Ruby based generation, or multiply build times by 4. |
The Liquid formatter lives in the feature/liquid-gen-rp-pages branch now. This doesn't necessarily make any sense but that's okay. Could/should maybe have been a tag. |
Instead of generating the output (oodles and oodles of
<p>
tags) with Ruby, we could pass the list ofLogLine
s into the page and use a Liquid template to generate the output.This would let it be more user-configurable, and also use Liquid for what it's meant to do.
The text was updated successfully, but these errors were encountered: