Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RP formatting to Liquid templates #57

Closed
irisfofs opened this issue Jan 8, 2016 · 4 comments
Closed

Move RP formatting to Liquid templates #57

irisfofs opened this issue Jan 8, 2016 · 4 comments
Assignees
Milestone

Comments

@irisfofs
Copy link
Owner

irisfofs commented Jan 8, 2016

Instead of generating the output (oodles and oodles of <p> tags) with Ruby, we could pass the list of LogLines into the page and use a Liquid template to generate the output.

This would let it be more user-configurable, and also use Liquid for what it's meant to do.

@irisfofs irisfofs self-assigned this Jan 8, 2016
@irisfofs irisfofs added this to the v0.4.0 milestone Jan 8, 2016
irisfofs added a commit that referenced this issue Jan 18, 2016
In preparation for working on #57, I set up a couple tests that look at
the output of rendering a page. This'll be useful.
@irisfofs
Copy link
Owner Author

So this revealed that using Liquid to generate the RP pages is actually really, really slow. Much slower than generating it with Ruby, the previous approach.

It's more expressive and is actually user-editable, but it seems like it might not be worth it.

Reopening this to have the changes moved into their own feature branch, to be potentially readded later.

@irisfofs irisfofs reopened this Jan 27, 2016
@irisfofs
Copy link
Owner Author

Jekyll 3.1 renders it in around 60% of the time, but it's still very slow.

@irisfofs
Copy link
Owner Author

Here's some rough timing, using some "representative sample data" (the collection of 138 RPs currently on my own site):

Jekyll  Liquid  Time
------  ------  ----
v3.1    Yes     23 s
v2.5.3  Yes     37 s
v2.5.3  No       9 s

Also note that using Jekyll v3.1 is currently not supported (see #66). So the options are keep the current, slightly icky Ruby based generation, or multiply build times by 4.

irisfofs added a commit that referenced this issue Jan 27, 2016
This reverts commit 4c79c00.

As mentioned in #57, generating the RP pages with Liquid takes a long
time. Rendering them with Ruby is much faster.
@irisfofs
Copy link
Owner Author

The Liquid formatter lives in the feature/liquid-gen-rp-pages branch now. This doesn't necessarily make any sense but that's okay. Could/should maybe have been a tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant