Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure hostname validation tests are used appropriately and add insp-issue tests #8

Open
DanielOaks opened this issue Oct 30, 2017 · 0 comments
Open

Ensure hostname validation tests are used appropriately and add insp-issue tests #8

DanielOaks opened this issue Oct 30, 2017 · 0 comments

Comments

@DanielOaks
Copy link
Member

Add failing tests with ' ' in the hostname to replicate that insp failing issue where they allowed spaces on hostnames.

Add to the comment on the file that clients should do NO HOSTNAME VALIDATION AT ALL and that it's 100% for servers to validate hostnames they get when they look up hostnames on incoming IPs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanielOaks