Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nickserv identify on freenode loses the race condition #12

Open
Habbie opened this issue Feb 18, 2019 · 0 comments
Open

nickserv identify on freenode loses the race condition #12

Habbie opened this issue Feb 18, 2019 · 0 comments

Comments

@Habbie
Copy link
Contributor

Habbie commented Feb 18, 2019

NickServ identify (as implemented through identity_pass in the irccat config) takes several seconds (7-8 on my measurements yesterday) to go through. This means that any JOINs that require the identification will fail.

This patch makes it work:

        if viper.IsSet("irc.identify_pass") && viper.GetString("irc.identify_pass") != "" {
+              log.Infof("Identifying to nickserv, then sleeping for fifteen seconds...")
               i.irc.SendRawf("NICKSERV IDENTIFY %s", viper.GetString("irc.identify_pass"))
+              time.Sleep(15 * time.Second)
        }

but that's terrible. A better approach would be to wait for :NickServ!NickServ@services. NOTICE HammerGit :You are now identified for .HammerGit.. - which was not really made for machine parsing.

For freenode, a better option is #11. However, OFTC does not support SASL so if anybody cares about logging in there, we'd need something that waits for confirmation from NickServ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant