Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve PiPoCollection.cpp #5

Open
josephlarralde opened this issue Nov 24, 2017 · 0 comments
Open

improve PiPoCollection.cpp #5

josephlarralde opened this issue Nov 24, 2017 · 0 comments
Assignees

Comments

@josephlarralde
Copy link
Collaborator

The std::map used by the factory might leak. Check that every call to "new" has its corresponding call to "delete", and that already existing PiPoCreators don't get instantiated more than once. (the constructor of PiPoHost : calls PiPoCollection::init(). What if we create a lot of hosts ?)

@josephlarralde josephlarralde self-assigned this Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant