combine camu.imubu.control and camu.target and simplify camu.select? #81
Replies: 7 comments
-
|
Beta Was this translation helpful? Give feedback.
-
I'm not working on those at the moment, Diemo.
I'm wondering how far into this we want to go, because strictly speaking:
there's also an inconsistency with analysis modules. Some tutorial patches
use "p corpus-analysis" (see #7) and some use "p descriptor-analysis" (see
#12); should these be standardized too (apart from the segmentation
tutorials which introduce them)?
…On Thu, Mar 9, 2023 at 4:45 PM diemo ***@***.***> wrote:
- looking further, camu.target was also used in camu.select (and
camu.voice, etc.)
- if we incorporate camu.target into camu.imubu.control, we can
simplify camu.select to have only 2 inlets!!!
- this would remove the cringeworthy decision which of the first 2
"control" inlet to use
- this means repatching in a few tutorials (3, 4, 5, 13) and examples,
tell me if you're working on any of these right now, @einbond
<https://github.com/einbond> @christophertrapani
<https://github.com/christophertrapani>
—
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIRYDC5ZCSB6DKNEBEHV65TW3H3IXANCNFSM6AAAAAAVTRVKRI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
Diemo, not working on those tutorials so please feel free to make the change!
Chris, if we can fix inconsistencies like that then let’s.
… On Mar 9, 2023, at 5:01 PM, Christopher Trapani ***@***.***> wrote:
I'm not working on those at the moment, Diemo.
I'm wondering how far into this we want to go, because strictly speaking:
there's also an inconsistency with analysis modules. Some tutorial patches
use "p corpus-analysis" (see #7) and some use "p descriptor-analysis" (see
#12); should these be standardized too (apart from the segmentation
tutorials which introduce them)?
On Thu, Mar 9, 2023 at 4:45 PM diemo ***@***.***> wrote:
>
> - looking further, camu.target was also used in camu.select (and
> camu.voice, etc.)
> - if we incorporate camu.target into camu.imubu.control, we can
> simplify camu.select to have only 2 inlets!!!
> - this would remove the cringeworthy decision which of the first 2
> "control" inlet to use
> - this means repatching in a few tutorials (3, 4, 5, 13) and examples,
> tell me if you're working on any of these right now, @einbond
> <https://github.com/einbond> @christophertrapani
> <https://github.com/christophertrapani>
>
> —
> Reply to this email directly, view it on GitHub
> <#76 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AIRYDC5ZCSB6DKNEBEHV65TW3H3IXANCNFSM6AAAAAAVTRVKRI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADRCSBLTST2NZUPBAPZWTFTW3H5GBANCNFSM6AAAAAAVTRVKRI>.
You are receiving this because you were mentioned.
|
Beta Was this translation helpful? Give feedback.
-
Shouldn't all of them use camu.analysis? |
Beta Was this translation helpful? Give feedback.
-
done with BIG commit f6cb8ea |
Beta Was this translation helpful? Give feedback.
-
dang, we forgot to think about backwards compatibility. |
Beta Was this translation helpful? Give feedback.
-
I fell into the trap myself, having used camu.select in other patches that suddenly stopped working... |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
All reactions