Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): make windows ci work by using c++14 for windows ci #297

Merged
merged 18 commits into from
Sep 18, 2024
Merged

chore(ci): make windows ci work by using c++14 for windows ci #297

merged 18 commits into from
Sep 18, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Aug 12, 2024 •
edited
Loading

resolves #298
resolves #275

  • fix windows compilation by using c++14 and not redefining timezone and gettimeofday
  • Remove support for 32-bit systems
  • List all available iqtree flags at top for easier discoverability
  • use latest ubuntu for linux aarch64 as well for consistency (as opposed to ubuntu 20.04)
  • Don't print erroneous vectorization message for arm systems
  • test in ci with minimum supported gcc (9) and cmake (3.10.2)

@corneliusroemer
chore(ci): Remove .travis.yml as travis is no longer used
982c040
@corneliusroemer
chore: Cleanup CMakeLists comments/usage
5981c95 
Remove 32-bit references from CMakeLists usage
List all available iqtree flags at top for easier discoverability
@corneliusroemer corneliusroemer marked this pull request as draft August 12, 2024 21:15
@corneliusroemer corneliusroemer changed the title chore: Cleanup CMakeLists comments/usage fix: make windows ci work by using c++14 Aug 12, 2024
@corneliusroemer corneliusroemer changed the title fix: make windows ci work by using c++14 fix: make windows ci work by using c++14 for windows ci Aug 12, 2024
@corneliusroemer corneliusroemer marked this pull request as ready for review August 12, 2024 23:19
@corneliusroemer corneliusroemer changed the title fix: make windows ci work by using c++14 for windows ci chore(ci): make windows ci work by using c++14 for windows ci Aug 12, 2024
bqminh
bqminh approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@bqminh bqminh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good. thanks!

@bqminh bqminh merged commit f9d442d into iqtree:master Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bqminh bqminh bqminh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails for windows Build issues on macOS 14.5: error: call to 'gettimeofday' is ambiguous
2 participants
@corneliusroemer @bqminh