Should we consistently convert OSPF areas into IPv4 addresses

[ipspace]

Right now, netlab checks the validity of OSPF areas (they could be IP addresses or 32-bit integers) but does not convert them into a unified format.

Would it make sense to convert integers into IP addresses (i.e. 0 into 0.0.0.0 or 1 into 0.0.0.1)? I vaguely remember someone already had to do that in a device configuration template.

What do you think @ssasso @jbemmel?

[ssasso]

You remember correctly, it has been done here:

netlab/netsim/ansible/templates/ospf/srlinux.macro.j2

Line 1 in 48149d2

{% macro format_area(a) -%}

and also here:

netlab/netsim/ansible/templates/ospf/routeros7.ospf-include.j2

Line 3 in 48149d2

{% set area = (ospf.area|default("0.0.0.0"))|string|ansible.utils.ipaddr('address') %}

I think we need to make sure other devices do not want the "reverse" to work ;)

[ipspace]

OK, will add the conversion into a test branch and run the multi-area OSPFv2 and OSPFv3 integration tests for all devices.

[ipspace]

Implemented in 938d366. Tested on all device images I have available, all passed the ospfv2/02-areas integration test.