Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find needs to have a way to get streaming results #22

Open
gammazero opened this issue May 23, 2023 · 1 comment
Open

Find needs to have a way to get streaming results #22

gammazero opened this issue May 23, 2023 · 1 comment

Comments

@gammazero
Copy link
Contributor

Need an option to ask for streaming find results, if the indexer being asked supports it.

@masih
Copy link
Member

masih commented May 23, 2023

I think it makes sense to do this by default. The HTTP Accept header supports specifying both non-streaming and streaming content type, and let the server return streaming wherever it is supported.
The client would then read the Content-Type header to see what the server returned.

The rationale for enabling this by default is much faster lookup, specially for CIDs that have a lot of providers, as well as the ability to set limit on the number of providers found.

For debugging, we can then have flags to override the Accept header sent from the CLI to be something explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants