fix!: reject duplicate map keys

Ref: ipld/ipld#259
ipld · Jan 6, 2023 · 65a37bc · 65a37bc
1 parent 1a8ca39
commit 65a37bc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -161,7 +161,7 @@
     "dep-check": "aegir dep-check"
   },
   "dependencies": {
-    "cborg": "^1.5.4",
+    "cborg": "^1.10.0",
     "multiformats": "^11.0.0"
   },
   "devDependencies": {

diff --git a/src/index.js b/src/index.js
@@ -192,6 +192,7 @@ const decodeOptions = {
   // safe-integer range, which may surprise users
   strict: true,
   useMaps: false,
+  rejectDuplicateMapKeys: true,
   /** @type {import('cborg').TagDecoder[]} */
   tags: []
 }

diff --git a/test/test-basics.spec.js b/test/test-basics.spec.js
@@ -183,4 +183,8 @@ describe('basic dag-json', () => {
     same(bytes.isBinary(output.bytes), true)
     same(CID.asCID(output.link), output.link)
   })
+
+  test('reject duplicate map keys', () => {
+    assert.throws(() => decode(new TextEncoder().encode('{"foo":1,"foo":2,"bar":3}')), /found repeat map key "foo"/)
+  })
 })