Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Worker cache stuck on older version #90

Open
3 tasks
SgtPooki opened this issue Jun 9, 2022 · 1 comment
Open
3 tasks

Service Worker cache stuck on older version #90

SgtPooki opened this issue Jun 9, 2022 · 1 comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@SgtPooki
Copy link
Contributor

SgtPooki commented Jun 9, 2022

Describe the bug
The context for this bug is from a FIL slack convo between @aschmahmann and @lidel.

Q: When I load the website I get one version and if I do ctrl+f5 (hard reset) in chrome I get another one. If I try loading the website again I'm back to the old version 😭

A: I think it is old cache in service worker – you should be able to purge old version by removing it (below is Firefox, but chromium have similar UI)

unregister service worker

Q: cool, that did it thanks 🙏. Is this a bug with an older version of explore.ipld.io or just a thing with service workers? Wouldn't want other people stuck on ancient versions here either

A: I think by default workers expire within 24h, usure why yours was stuck. guess: i think the old version is kept alive as long you have a tab open or something, so if you used it often it was kept around

Q: idk, the version I had was using secio (I could see the wss requests in the browser) and obviously making no progress which is ancient. Pretty sure I've turned off my computer, updated chrome, and probably (although I guess not for sure) closed all my windows during that time.


Potential action items for this bug report

  • Simple analysis of service worker to ensure any obvious stuck-cache chances are removed
  • Ensure service-worker checks for latest version
  • Test for service worker to get latest version
@SgtPooki SgtPooki added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours P2 Medium: Good to have, but can wait until someone steps up labels Jun 9, 2022
@SgtPooki
Copy link
Contributor Author

@alvin-reyes any chance you could take a look at this? @lidel said you were the last person to deal with this website and you may be able to get us a quicker win

@SgtPooki SgtPooki removed the need/triage Needs initial labeling and prioritization label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

1 participant