Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo for the library #217

Closed
silkfire opened this issue Apr 24, 2019 · 11 comments
Closed

Logo for the library #217

silkfire opened this issue Apr 24, 2019 · 11 comments
Milestone

Comments

@silkfire
Copy link
Contributor

silkfire commented Apr 24, 2019

Have you considered to add a logo to your library? If you want, I can come up with a few design ideas. Something that would aptly fit the name, of course :)

@ipjohnson
Copy link
Owner

I actually hadn’t, I’d definitely be interested in seeing your designs.

@silkfire
Copy link
Contributor Author

Great, I'll come back to you in a few days with my suggestions. Any preference when it comes to colors, shapes or imagery to be used?

@ipjohnson
Copy link
Owner

Thanks that would be really cool. Maybe greens or blues?

@silkfire
Copy link
Contributor Author

Here's a couple of designs I made in Illustrator. What do you think?

grace-1
grace-2
grace-3

@ipjohnson
Copy link
Owner

Those look nice, I think I'll go with the bottom one and see if I can get it in for the 7.0 release

@silkfire
Copy link
Contributor Author

silkfire commented Apr 25, 2019

Wooooow, glad you found one you liked. Looking forward to seeing it live.

Would you like me to make a PR where I include it in an /img/ folder? I assume you know how to refer to it from the .nuspec?

If you want the colors adjusted just tell me and I'll fine tune them to your liking.

@ipjohnson
Copy link
Owner

Sure a PR would be great, could you possible do a couple size 256,128,64?

@silkfire
Copy link
Contributor Author

See pull request at #219

@ipjohnson
Copy link
Owner

Awesome, thanks!

@ipjohnson
Copy link
Owner

Looks great. I'm going to get it added into the other satellite packages and should be ready for release.

Thanks again!

@silkfire
Copy link
Contributor Author

silkfire commented Apr 25, 2019

@ipjohnson My pleasure. This should give the package a wee bit of character :)

Btw, please make sure to edit the link to the SVG icon in the README.md from:

https://raw.githubusercontent.com/silkfire/Grace/e0415b74141fbc17c88cbec7dd978460b3c9300a/img/logo.svg?sanitize=true

to

https://raw.githubusercontent.com/ipjohnson/Grace/7c24bfa184bc4b984e64b9e8d2457200a64a0724/img/logo.svg?sanitize=true

As it was pointing to the image relative to my fork.

@ipjohnson ipjohnson added this to the 7.0 milestone May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants