Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Query Parameters (?format=car / ?format=raw) #356

Open
agmap opened this issue Sep 12, 2024 · 1 comment
Open

Request Query Parameters (?format=car / ?format=raw) #356

agmap opened this issue Sep 12, 2024 · 1 comment
Labels
bug Something isn't working effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up

Comments

@agmap
Copy link

agmap commented Sep 12, 2024

https://<cid>.ipfs.inbrowser.link/filename.json?format=car
--> ipfs.io delivers the CAR file only of the filename.json
--> serviceworker delivers the full CAR file of the full cid directory.

https://<cid>.ipfs.inbrowser.link/filename.json?format=raw
--> not working
@SgtPooki SgtPooki added bug Something isn't working effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful need/analysis Needs further analysis before proceeding P1 High: Likely tackled by core team if no one steps up P2 Medium: Good to have, but can wait until someone steps up and removed P1 High: Likely tackled by core team if no one steps up labels Nov 4, 2024
@lidel
Copy link
Member

lidel commented Nov 22, 2024 •
edited
Loading

@SgtPooki until we implement this, for now return an explicit 501 Not Implemented error until https://specs.ipfs.tech/http-gateways/trustless-gateway/ is implemented, to avoid user confusion when unsupported ?format=car|raw and Accept: application/vnd.ipld.* is passed in request?

Broken responses make ecosystem feel flaky, clear 501 is better for end users.

Once we get to this, related conformance tests that will help with implementing the spec:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @SgtPooki @agmap